fix(input): underline showing at end if text-align is set #5280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the `align` input binding has been removed in favor of the CSS property `text-align`. If a developer sets the `text-align` property to `end` the text will start from the end and also the input underline will show incorrectly start from the end. Setting the absolute positioned underline to `left: 0` ensures that the underline always shows-up correctly (because the `mat-input-underline` is inside of a relative container) Fixes angular#5272
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the
aligninput binding has been removed in favor of the CSS propertytext-align.If a developer sets the
text-alignproperty toendthe text will start from the end and also the input underline will show incorrectly start from the end.Setting the absolute positioned underline to
left: 0ensures that the underline always shows-up correctly (because themat-input-underlineis inside of a relative container)Note: This still works with RTL because the
mat-input-underlinecontainer is inside of a relative container and it uses a width of100%)Fixes #5272